hubgeter commented on code in PR #68259:
URL: https://github.com/apache/doris/pull/68259#discussion_r4069369081
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -2418,7 +2426,10 @@ private Split createIcebergSplit(FileScanTask
fileScanTask) throws UserException
}
split.setTableFormatType(TableFormatType.ICEBERG);
split.setTargetSplitSize(selectFeSplitSize(fileScanTask,
targetSplitSize));
- if (isPartitionedTable) {
+ // Gate on the table's spec HISTORY, not on the current default spec:
a file written under an older
+ // identity spec keeps its partition values in the manifest, and they
are the only source for an
+ // identity partition column that the physical file does not store.
+ if (hasPartitionedSpec) {
Review Comment:
Correction to my previous reply: the regression case has been removed from
this PR at the author's request, so only the FE-side unit tests remain. The
classification fix itself is unchanged. The BE half — that the v2 column mapper
materializes the split value for the now-partition-key column — is therefore
covered by code review only, not by a test in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
