yx-keith commented on PR #67976:
URL: https://github.com/apache/doris/pull/67976#issuecomment-5772733464
1. Correctness: `getOnClauseCondition()` includes `markJoinConjuncts`.
`InApplyToJoin` keeps a nullable IN equality there precisely to tell NULL from
FALSE. Inferring from it pushes `c.parent_id = 'P1'` into the right side,
dropping `parent_id IS NULL` rows and turning the mark from NULL into FALSE
(derived from code, not run):
```sql
-- p = {'P1'}, c.parent_id = {NULL, 'P2'}
SELECT p.id, p.id IN (SELECT parent_id FROM c) FROM p WHERE p.id = 'P1';
-- expected NULL; after this change -> FALSE
```
With NOT IN inside a CASE WHEN, the wrong branch is taken. For mark joins,
please infer only from hash/other conjuncts. The EXISTS case in the description
is unaffected, since its correlation predicates live there. An IN / NOT IN test
over a nullable column would pin this down.
2. Besides the MysqlConnectProcessor change, `.mvn-settings.xml` and
`mvn-proxy.sh` (local sandbox proxy/toolchain config) were committed by
mistake. Please remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
