0AyanamiRei commented on PR #67696: URL: https://github.com/apache/doris/pull/67696#issuecomment-5758010306
Absorbed into the Kinesis shard topology change, closing this draft. - `RoutineLoadJob.modifyCommonJobProperties`: `UNIQUE_KEY_UPDATE_MODE` is parsed and validated before any other job property is mutated, so a failed validation leaves the job untouched. Landed verbatim. - `KinesisRoutineLoadJob.modifyPropertiesInternal`: the validate-before-mutate restructure landed, extended with the `sourceGeneration` guard so a pending asynchronous LATEST scan for the old source is invalidated when ALTER changes stream/region/endpoint. - `KinesisRoutineLoadJobTest`: `testFailedAlterPreservesStateAndShardDiscovery`, `testFailedCommonPropertyValidationPreservesKinesisState` and `testSuccessfulAlterMatchesJournalReplay` are in the branch. The shard-discovery assertions were adapted to the topology API (`getAllKinesisShardInfos`, and the explicit-shard case now also refreshes the shard list instead of skipping it, since explicit shards are validated against `ListShards`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
