This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new c91757aed0b [fix](test) Reuse the suite connection when polling
lower-case tables (#68329)
c91757aed0b is described below
commit c91757aed0b44ffbd23c9f0859c428c2033f95ba
Author: Gabriel <[email protected]>
AuthorDate: Mon Sep 21 21:34:50 2026 +0800
[fix](test) Reuse the suite connection when polling lower-case tables
(#68329)
### What problem does this PR solve?
Related PR: #68101
`test_lower_case_meta_with_lower_table_conf_show_and_select` can exhaust
the test user's connection quota while waiting for tables. Each
independent Awaitility wait creates a polling thread whose JDBC
connection is stored in `SuiteContext.threadLocalConn`; suite-thread
cleanup cannot close those connections. In [build
1053466](http://43.132.222.7:8111/viewLog.html?buildId=1053466&buildTypeId=Doris_External_Regression),
the polling thread repeatedly received `Reach limit of connections`
before the case reported a 10-second metadata wait timeout.
Use the existing `awaitUntil(10, 1)` helper, which polls on the suite
thread and reuses its JDBC connection. Add a comment explaining the
connection ownership requirement and remove the unused imports. This
preserves the polling condition, interval and configured wait budget
without increasing connection limits.
---
...st_lower_case_meta_with_lower_table_conf_show_and_select.groovy | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git
a/regression-test/suites/external_table_p0/lower_case/test_lower_case_meta_with_lower_table_conf_show_and_select.groovy
b/regression-test/suites/external_table_p0/lower_case/test_lower_case_meta_with_lower_table_conf_show_and_select.groovy
index a71dd38ca0e..240be7f5de3 100644
---
a/regression-test/suites/external_table_p0/lower_case/test_lower_case_meta_with_lower_table_conf_show_and_select.groovy
+++
b/regression-test/suites/external_table_p0/lower_case/test_lower_case_meta_with_lower_table_conf_show_and_select.groovy
@@ -15,10 +15,6 @@
// specific language governing permissions and limitations
// under the License.
-import java.util.concurrent.Executors
-import java.util.concurrent.TimeUnit
-import org.awaitility.Awaitility
-
suite("test_lower_case_meta_with_lower_table_conf_show_and_select",
"p0,external") {
String jdbcUrl = context.config.jdbcUrl
@@ -30,7 +26,8 @@
suite("test_lower_case_meta_with_lower_table_conf_show_and_select", "p0,external
// String driver_url = "mysql-connector-j-8.4.0.jar"
def wait_table_sync = { String db ->
- Awaitility.await().atMost(10, TimeUnit.SECONDS).pollInterval(1,
TimeUnit.SECONDS).until{
+ // Poll on the suite thread so its ThreadLocal JDBC connection is
reused and closed by suite cleanup.
+ awaitUntil(10, 1) {
try {
def res = sql "show tables from ${db}"
return res.size() > 0;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
