morningman opened a new pull request, #4163:
URL: https://github.com/apache/doris-website/pull/4163

   ## What
   
   1. **all-release**: the Doris Core row's link now reads "Release Notes" (EN 
+ zh-CN), matching the other rows.
   2. **Markdown link colour**: `.markdown a` already used 
`--ifm-color-primary`, but three brand themes (Steel Cyan `#2C2C34`, Lava & 
Black `#121212`, Obsidian Gold `#000`) have a near-black primary, so links on 
those themes were indistinguishable from body text (`#1F1F26`) and only 
revealed themselves by the hover underline.
   
   ## How
   
   - `src/scss/_variables.scss`: new `--brand-link` token. Defaults to 
`--brand-primary` (no change on Doris Green and the other coloured themes); the 
three near-black themes override it with a readable shade of their accent — 
Steel Cyan `#007C9E`, Lava `#CC3A00`, Obsidian Gold `#8A6D00` (all ≥ 4.6:1 on 
white).
   - `src/scss/components/markdown.scss`: links use `--brand-link` at rest with 
no underline, underline on hover (`text-underline-offset: 0.15em`). Inline code 
wrapped in a link (`[`foo`](...)`) now inherits the link colour instead of the 
grey `.markdown code` colour, so those links are recognisable too.
   - The hover rule keeps (0,1,1) specificity via `:where` and takes its value 
from Infima's `--ifm-link-hover-decoration`, so `.button`, DocCard and the 
page-level card anchors in community-badges / contribute-to-doris keep opting 
out of the underline.
   - `src/components/getting-started-card/style.scss`: explicit 
`text-decoration: none` on hover. The global `a:hover` underline propagated 
through the whole card text (pre-existing, e.g. on install/intro).
   
   ## Verified
   
   Dev server + Chrome, four themes (doris / blue / read / yellow-black), on 
`/releases/all-release` and a docs page with a code-wrapped link: rest colour = 
`--brand-link`, no underline; hover keeps the colour and underlines; 
GettingStartedCard hover no longer underlines.
   
   | Doris Green | Steel Cyan |
   | --- | --- |
   | Lava & Black | Obsidian Gold |
   
   (first row shown in hover state)
   
   ![four themes](https://github.com/user-attachments/assets/placeholder)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to