Gabriel39 commented on PR #68161:
URL: https://github.com/apache/doris/pull/68161#issuecomment-5756966189
Please leave the V1 reader fix out of this PR and scope the timestamp
precision-evolution fix to V2 and JNI.
Specifically, please drop the V1 changes in
`be/src/format/column_type_convert.{h,cpp}`,
`be/src/format/orc/vorc_reader.cpp`, and
`be/src/format/parquet/vparquet_reader.cpp`, together with the V1-only
converter tests and the newly added V1 precision-evolution regression
cases/expected outputs. Keep the shared fixtures needed by V2/JNI and preserve
existing unrelated coverage.
Please also update the PR description and release note to state the V2/JNI
scope explicitly. V1 should retain its existing behavior in this PR; this
request supersedes my earlier suggestion to add a Paimon-specific conversion
policy to V1. The two outstanding JNI correctness findings still need to be
addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
