github-actions[bot] commented on code in PR #68198: URL: https://github.com/apache/doris/pull/68198#discussion_r4056667623
########## regression-test/suites/point_query_p0/test_point_query_light_schema_change.groovy: ########## @@ -0,0 +1,80 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// A short-circuit point query reading a column that a light schema change just added, before +// any load has carried the new schema to the BE. +// +// BaseTablet::_max_version_schema only moves forward when a rowset is written, and the lookup +// request carries no schema of its own, so in that window the BE's tablet schema still lacks +// the column. The column store fallback used to fail the query with +// "field name is invalid. field=<col>" +// instead of answering with the column's default, which is what every segment holds for it. +// +// The fallback is only reached when the row store does not cover the column, i.e. with a +// partial "row_store_columns". A full row store answers from jsonb and never gets here. +suite("test_point_query_light_schema_change", "p0") { + def tableName = "point_query_lsc_added_column" Review Comment: [P2] Follow the repository's single-table regression convention here. This suite has one ordinary table, but defines `tableName` and interpolates it throughout. `AGENTS.md` and the code-review checklist require hardcoding the table name in simple tests; please replace the variable/interpolations with the literal `point_query_lsc_added_column`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
