airborne12 commented on code in PR #67918:
URL: https://github.com/apache/doris/pull/67918#discussion_r4056872322
##########
fe/fe-core/src/main/java/org/apache/doris/indexpolicy/IndexPolicyMgr.java:
##########
@@ -140,7 +195,7 @@ private void
validateReferencedComponentsUsableLocked(String analyzerName, Index
return;
}
for (String tokenFilterName : tokenFilterNames.split(",\\s*")) {
- IndexPolicy tokenFilter =
nameToIndexPolicy.get(normalizeKey(tokenFilterName));
Review Comment:
Fixed in `48ac1e45c1e`. `validateReferencedComponentsUsableLocked()` now
resolves the tokenizer through `getPolicyByNameLocked()` and rejects an exact
non-`TOKENIZER` binding before checking whether the tokenizer is invalid.
The new image round-trip test covers both case-collision directions—invalid
exact/valid normalized and valid exact/invalid normalized—as well as a
wrong-type exact binding. It failed before the fix because the invalid exact
`Foo` binding was accepted, then passed after the change. The full
`PolicyValidatorTests` class passes 39/39, and `./build.sh --fe` passes with
Checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
