github-actions[bot] commented on code in PR #66913:
URL: https://github.com/apache/doris/pull/66913#discussion_r4056372035
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalTable.java:
##########
@@ -322,14 +301,14 @@ public List<Column> getBaseSchemaForDisplay(boolean full)
{
return getBaseSchema(full);
}
try {
- return catalog.getExecutionAuthenticator().execute(() -> {
+ return IcebergUtils.withIcebergTable(this, table -> {
// Schema-only changes need not advance the current snapshot.
Resolve the current
// table schema and hidden columns from one retained metadata
generation.
- Table table =
IcebergSnapshotCacheValue.retainTableGeneration(getIcebergTable());
- List<Column> schema =
IcebergUtils.parseSchemaForDisplay(table.schema(),
+ Table retainedTable =
IcebergSnapshotCacheValue.retainTableGeneration(table);
+ List<Column> schema =
IcebergUtils.parseSchemaForDisplay(retainedTable.schema(),
catalog.getEnableMappingVarbinary(),
catalog.getEnableMappingTimestampTz());
Review Comment:
[P1] Keep display mapping options on the retained generation
`withIcebergTable` now pins and authenticates G1 correctly, but this new
display callback still reads both mapping options from the mutable live
catalog. If an ALTER/reset lands after the borrow, DESCRIBE/PROC can convert G1
fields with G2 semantics (for example varbinary/UUID or timestamp-with-zone
mapping) even though the retained table remains usable. The table cache value
already captures these flags; carry them through this scoped projection and add
a reset barrier. This is distinct from the earlier display-borrower thread:
access is now scoped, but the generation context is still incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
