github-actions[bot] commented on code in PR #67918:
URL: https://github.com/apache/doris/pull/67918#discussion_r4056120490
##########
be/src/storage/index/inverted/inverted_index_writer.cpp:
##########
@@ -329,6 +333,9 @@ Status
InvertedIndexColumnWriter<field_type>::new_inverted_index_field(const cha
} catch (const CLuceneError& e) {
return Status::Error<ErrorCode::INVERTED_INDEX_CLUCENE_ERROR>(
"CLuceneError create new index field error: {}", e.what());
+ } catch (const Exception& e) {
Review Comment:
[P1] Cover ARRAY token-stream creation with this Status boundary
This new catch converts lazy custom-IK failures for the scalar
`reusableTokenStream()` path, and `add_document()` now catches failures raised
later while consuming a stream. The ARRAY path does neither:
`add_array_values()` calls `_analyzer->tokenStream()` directly at line 467,
before `add_document()`. If the first IK dictionary load fails,
`CustomAnalyzer::create_components()` now throws `doris::Exception` there, and
the normal `ArrayColumnWriter::append_data()` caller only uses
`RETURN_IF_ERROR`, so the exception escapes a `Status` API. (The separate
`IndexBuilder` path has an outer catch, but ordinary segment writes do not.)
Please wrap ARRAY stream creation/publication in the same exception-to-Status
boundary and cover a missing-dictionary custom-IK ARRAY write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
