morningman commented on PR #68101: URL: https://github.com/apache/doris/pull/68101#issuecomment-5747455570
Rebased onto master `1f41d4223bf` (no conflicts; every commit replays unchanged except for import context in `DorisFlightSqlProducerTest`). The P0 / cloud_p0 runs since 09-18 were red only in `arrow_flight_sql_p0/test_connection_quota`: #67820 had made `getFlightInfoStatement` wrap the pool's RESOURCE_EXHAUSTED as `INTERNAL: get flight info statement failed, Reach limit of connections ...` (build 1051523), and the pipelines compile the PR merged into master. #68221 restored the pass-through and is in this base now. The static review's four items were addressed in `b446ac89ac8` (`a435eae450b` before the rebase); replied per thread. In short: admission of the pool / Flight / user quotas is one critical section in `ConnectPoolMgr.registerConnection`; exactly one `ConnectContext` is published per bearer token (`FlightSessionsWithTokenManager` serializes creation, re-checks the index and re-validates the token after registration); the token cache floors the sub-quota term at 1 so a legal sub-quota of 0 still refuses with RESOURCE_EXHAUSTED; the retained-buffer test is gone (its leak could not be released after the allocator-close failure it forced). Local run on the rebased head `b446ac89ac8`: FE UT 72/72 (`ConnectPoolMgrTest`, `ConnectionExceedTest`, `DorisFlightSqlProducerTest`, `DorisFlightSqlServiceTest`, `FlightProtocolAdapterTest`, `MysqlProtocolAdapterTest`, `MetricsTest`, plus the two protocol golden tests), fe-core checkstyle 0 violations, and `arrow_flight_sql_p0` 11/11 against a 1 FE + 1 BE cluster built from this head -- `test_connection_quota` sees the RESOURCE_EXHAUSTED refusal again (no tolerated INTERNAL in the run). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
