github-actions[bot] commented on code in PR #67395:
URL: https://github.com/apache/doris/pull/67395#discussion_r4055881720


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DeleteFromUsingCommand.java:
##########
@@ -55,6 +57,15 @@ public void run(ConnectContext ctx, StmtExecutor executor) 
throws Exception {
                     + " Please check the following session variables: "
                     + ctx.getSessionVariable().printDebugModeVariables());
         }
+        TableIf table = 
RelationUtil.getTable(RelationUtil.getQualifierName(ctx, nameParts),
+                ctx.getEnv(), Optional.empty());
+        Optional<RowLevelDmlTransform> transform = 
RowLevelDmlRegistry.find(table);
+        if (transform.isPresent()) {
+            RowLevelDmlArgs args = RowLevelDmlArgs.forDelete(table, nameParts, 
tableAlias,

Review Comment:
   [P2] Build EXPLAIN from the same DELETE USING arguments
   
   Execution now uses `handleCte(logicalQuery)` with 
`deduplicateTargetRows=true`, but this subclass inherits `getExplainPlan()`, 
which uses the raw `logicalQuery` and the overload defaulting deduplication to 
false. A CTE-backed EXPLAIN can lose its CTE definition, and an ordinary USING 
EXPLAIN omits the primary-key aggregate that execution applies. Share the 
argument builder or override `getExplainPlan()` so EXPLAIN matches the executed 
plan.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to