github-actions[bot] commented on code in PR #67067:
URL: https://github.com/apache/doris/pull/67067#discussion_r4055867998
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1971,7 +1971,7 @@ public void setMaxJoinNumberOfReorder(int
maxJoinNumberOfReorder) {
}
@VarAttrDef.VarAttr(name = MAX_JOIN_NUMBER_BUSHY_TREE)
- private int maxJoinNumBushyTree = 8;
+ private int maxJoinNumBushyTree = 9;
Review Comment:
[P2] Keep the nine-way CBO expansion behind a separate control
For `Filter(equalities) -> (... nine inner/cross-join inputs ...)`,
`ReorderJoin` records `maxNAryInnerJoin=9`. Even with
`enable_join_reorder_before_eager_agg=false` (or with no aggregate), this new
default then makes `OptimizeGroupExpressionJob` select the bushy rule set where
the base default selected zig-zag. That adds both association directions and
exchange exploration for queries outside the new feature; a fully connected
nine-input graph already has 9,330 nontrivial subset splits before
orientations/implementations, near the 10,000-expression memo cap. Please
retain 8, gate this independent expansion separately, or document it and add a
reliable-statistics nine-table feature-off planning-budget regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
