morningman commented on PR #68101:
URL: https://github.com/apache/doris/pull/68101#issuecomment-5728270048
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68101
commit: d5681e773f9f3ac238fd611aafde74b972207ac0
base: dea1b99e528f57b96d9b3bd9fa68f4dc3e726d32
reviewed_at: 2026-09-18T17:47+08:00
reviewer: morningman
model: claude-opus-5
effort: max
findings: {blocker: 0, major: 0, minor: 1, nit: 3}
rounds: 1
converged: true
```
**Notes for maintainers**
- Fourth review (supersedes the `237b81a` receipt). Increment: the
capped-value startup WARN now states the consequence
and the remedy (the previous review's F-03); two test-only commits make
`test_connection_quota` open its MySQL
connections on the FE serving the Flight endpoint and count that FE's
connections alone
(`fetch_all_fe_for_system_table = false`), and grant the quota user a
compute group in cloud mode. Production code is
otherwise byte-identical to the `237b81a` head; all earlier findings are
fixed or declared pending (doc PR).
- One Minor, test-only: the single-FE anchoring assumes the FE serving
`extArrowFlightSqlHost:Port` listens for MySQL
at that host on `jdbcUrl`'s port - true for every pipeline configuration
in the repository, but unasserted, and the
two-FE pipeline the commit answers has no configuration here; where it
fails the suite is deterministically red with
a message that blames the pool. Suggested: assert it via `SHOW FRONTEND
CONFIG LIKE 'arrow_flight_sql_port'` on the
count connection, or derive the query port from `SHOW FRONTENDS`.
- Verified read-only: the URL-rewrite regex matches every pipeline
`jdbcUrl`; with the variable off the connected FE
lists only its own pool; the cloud grant follows the sibling suites' idiom
and is removed by `DROP USER`. No build,
unit test or cluster run by the reviewer.
- Three Nits: the URL rewrite silently keeps the original host when the
regex does not match; the release note's new
qualifier names the sub-quota where the token cache is the threshold above
qe_max_connection = 8192; the doc PR to
doris-website is still to be opened.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
