HappenLee commented on PR #68097: URL: https://github.com/apache/doris/pull/68097#issuecomment-5714396753
/review Please re-review the complete PR at head `b21ac408703240c9237f5b3ba6a7c7c586de863e`. This update addresses the previous review's predicate-simplification and point-query I/O findings: - Always-true TSO pruning reuses the first-phase logical reader and its virtual ZoneMap, including cold caches, while respecting other expression dependencies. - Point queries always treat TSO as unavailable from JSONB and read it through the normal missing-column loop, using the pinned source rowset, query I/O context, cache-write limiter and profile statistics. Empty row-store projections skip JSONB; ordinary missing-column restrictions and delete-sign reads are preserved. Please focus on row-store projection/default-fill semantics, TSO-only and mixed output slots, the disabled column-store setting, multi-version physical TSO reads, limiter/statistics propagation, rowset lifetime, and whether any unnecessary I/O remains. Also review the rest of the PR for regressions. Validation: 85 ASAN unit tests passed in 8 suites. The physical TSO tests use the real CachedRemoteFileReader with a local object-storage stand-in and cover zero/exhausted cache-write budgets, an unlimited control, and query I/O statistics. Formatting and build hygiene passed. SQL regression coverage was extended but not run; no live cloud integration test was run. clang-tidy remains blocked by the pre-existing unmatched NOLINTEND in core/types.h; newly introduced diagnostics were corrected and rechecked. The two linked-rowset producer issues from the previous review were confirmed to predate this PR and are tracked separately; their implementations are unchanged in this update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
