xy720 commented on code in PR #68038:
URL: https://github.com/apache/doris/pull/68038#discussion_r4033239440
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVRelationManager.java:
##########
@@ -218,12 +224,15 @@ public void refreshMTMVCache(MTMVRelation relation,
BaseTableInfo mtmvInfo) {
removeMTMV(mtmvInfo);
return;
}
+ Set<BaseTableInfo> staleTables = mtmvToBaseTables.get(mtmvInfo);
Review Comment:
这个 race 是 PR #62606 引入的既有行为——旧版 removeMTMV 也没有加锁；本 PR
只换了删除策略，没有扩大窗口。建议作为另起一个pr作为独立补丁统一处理所有 register/unregister 路径。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
