Gabriel39 commented on PR #68027: URL: https://github.com/apache/doris/pull/68027#issuecomment-5698713643
Scoped the CSV reader fix to FileScannerV2 and restored `be/src/format/` and `be/test/format/` to the PR base. The OpenCSV parser, physical-record helper, and reader tests now live under the V2 directories. The external regression explicitly enables V2 and restores the original session setting afterward. Also corrected the CSV regression fixture: Hive decodes the disabled-character SQL literal to NUL, which a PostgreSQL-backed metastore cannot persist in text properties. The integration fixture now uses four valid dialects. Disabled quote/escape settings and binary NUL data remain covered by the Hive oracle and V2 unit tests. Validation: 43 BE tests passed under ASAN, 480 Hive connector tests passed, Groovy compilation and FE Checkstyle passed, and all affected C++ files passed clang-format 16. License Eye and header hygiene passed. A real Hive SQL-decoding/PostgreSQL probe reproduced the original metadata failure and successfully persisted all 12 revised property values. The V2 parser and line helper are clang-tidy clean; existing reader/header diagnostics still prevent a clean repository-wide result. Full external regression validation awaits the new CI run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
