924060929 commented on code in PR #67906:
URL: https://github.com/apache/doris/pull/67906#discussion_r4001667012
##########
be/src/exec/rowid_fetcher.cpp:
##########
@@ -437,6 +439,28 @@ const std::string
RowIdStorageReader::TopNLazyMaterializationSecondPhaseRowsRead
const std::string
RowIdStorageReader::TopNLazyMaterializationSecondPhaseSegmentsRead =
"TopNLazyMaterializationSecondPhaseSegmentsRead";
+bool RowIdStorageReader::should_use_file_scanner_v2(const TQueryOptions&
query_options,
+ const
TFileScanRangeParams& scan_params,
+ const TFileRangeDesc&
range) {
+ const auto format_type =
+ range.__isset.format_type ? range.format_type :
scan_params.format_type;
+ // Phase two inherits the query options, including the Thrift presence
bit. Reuse phase one's
+ // policy so disabling V2 (or an older payload omitting the option) also
keeps row fetches on V1.
+ return FileScanLocalState::should_use_file_scanner_v2(query_options,
false, scan_params) &&
Review Comment:
This remains a blocker at current head `32d20cb0d5` because Doris uses a
BE-first rolling-upgrade order. During the mixed-version window, an old FE
cannot send field 38 but can still send `enable_file_scanner_v2=true`. The new
BE then selects V2 here, and a lazy Iceberg `_file`/`_pos` slot that was pruned
from phase one is rebuilt as a physical column, producing a missing-column
default instead of the metadata value.
Please use field-38 presence as the row-fetch capability boundary (or add
equivalent version negotiation): absent field -> V1 fallback; present empty map
-> V2 with all ordinary columns. Please also add an old-FE/new-BE test covering
this exact payload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
