[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16412: [enhancement](stream receiver) make stream receiver exception safe

[via GitHub]

github-actions[bot] commented on code in PR #16412:
URL: https://github.com/apache/doris/pull/16412#discussion_r1095772966


##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -111,23 +111,24 @@ TEST_F(TestBlockSpill, TestInt) {
     vectorized::BlockSpillReaderUPtr spill_block_reader;
     block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);

Review Comment:
   warning: 'profile_' is a private member of 'doris::TestBlockSpill' 
[clang-diagnostic-error]
   ```cpp
       block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);
                                                                                
         ^
   ```
   **be/test/vec/core/block_spill_test.cpp:79:** declared private here
   ```cpp
       RuntimeProfile* profile_;
                       ^
   ```
   



##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -159,13 +160,14 @@
     vectorized::BlockSpillReaderUPtr spill_block_reader;
     block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);

Review Comment:
   warning: 'profile_' is a private member of 'doris::TestBlockSpill' 
[clang-diagnostic-error]
   ```cpp
       block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);
                                                                                
         ^
   ```
   **be/test/vec/core/block_spill_test.cpp:79:** declared private here
   ```cpp
       RuntimeProfile* profile_;
                       ^
   ```
   



##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -262,14 +265,15 @@
     vectorized::BlockSpillReaderUPtr spill_block_reader;
     block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);

Review Comment:
   warning: 'profile_' is a private member of 'doris::TestBlockSpill' 
[clang-diagnostic-error]
   ```cpp
       block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);
                                                                                
         ^
   ```
   **be/test/vec/core/block_spill_test.cpp:79:** declared private here
   ```cpp
       RuntimeProfile* profile_;
                       ^
   ```
   



##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -441,27 +447,28 @@
     vectorized::BlockSpillReaderUPtr spill_block_reader;
     block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);

Review Comment:
   warning: 'profile_' is a private member of 'doris::TestBlockSpill' 
[clang-diagnostic-error]
   ```cpp
       block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);
                                                                                
         ^
   ```
   **be/test/vec/core/block_spill_test.cpp:79:** declared private here
   ```cpp
       RuntimeProfile* profile_;
                       ^
   ```
   



##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -211,25 +213,26 @@
     vectorized::BlockSpillReaderUPtr spill_block_reader;
     block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);

Review Comment:
   warning: 'profile_' is a private member of 'doris::TestBlockSpill' 
[clang-diagnostic-error]
   ```cpp
       block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);
                                                                                
         ^
   ```
   **be/test/vec/core/block_spill_test.cpp:79:** declared private here
   ```cpp
       RuntimeProfile* profile_;
                       ^
   ```
   



##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -320,14 +324,15 @@
     vectorized::BlockSpillReaderUPtr spill_block_reader;
     block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);

Review Comment:
   warning: 'profile_' is a private member of 'doris::TestBlockSpill' 
[clang-diagnostic-error]
   ```cpp
       block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);
                                                                                
         ^
   ```
   **be/test/vec/core/block_spill_test.cpp:79:** declared private here
   ```cpp
       RuntimeProfile* profile_;
                       ^
   ```
   



##########
be/test/vec/core/block_spill_test.cpp:
##########
@@ -376,14 +381,15 @@
     vectorized::BlockSpillReaderUPtr spill_block_reader;
     block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);

Review Comment:
   warning: 'profile_' is a private member of 'doris::TestBlockSpill' 
[clang-diagnostic-error]
   ```cpp
       block_spill_manager->get_reader(spill_block_writer->get_id(), 
spill_block_reader, profile_);
                                                                                
         ^
   ```
   **be/test/vec/core/block_spill_test.cpp:79:** declared private here
   ```cpp
       RuntimeProfile* profile_;
                       ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org