cambyzju commented on code in PR #16400: URL: https://github.com/apache/doris/pull/16400#discussion_r1095680392
########## be/src/olap/types.cpp: ########## @@ -262,14 +262,13 @@ TypeInfoPtr get_type_info(const TabletColumn* col) { } TypeInfoPtr clone_type_info(const TypeInfo* type_info) { - if (is_scalar_type(type_info->type())) { - return create_static_type_info_ptr(type_info); - } else if (type_info->type() == OLAP_FIELD_TYPE_MAP) { + auto type = type_info->type(); + if (type == OLAP_FIELD_TYPE_MAP) { Review Comment: ```suggestion if (UNLIKELY(type == OLAP_FIELD_TYPE_MAP)) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org