github-actions[bot] commented on code in PR #67770:
URL: https://github.com/apache/doris/pull/67770#discussion_r3979911279
##########
build.sh:
##########
@@ -1181,6 +1185,29 @@ if [[ "${BUILD_FE}" -eq 1 ]]; then
mkdir -p "${DORIS_OUTPUT}/fe/plugins/hadoop_conf/"
mkdir -p "${DORIS_OUTPUT}/fe/plugins/java_extensions/"
+ # Shared library bundles: libraries that every plugin needing them must
load from ONE place,
+ # because their classes inherit across jars and their static state
(FileSystem.CACHE, the UGI
+ # login, the FileSystem service registry) is what makes two plugins agree
about one cluster.
+ # SharedLibraryLayer turns this directory into the parent classloader of
every filesystem and
+ # connector plugin. Deliberately at plugins/ level and not under
plugins/filesystem or
+ # plugins/connector: DirectoryPluginRuntimeManager treats every direct
subdirectory of those as
+ # a plugin, and would report this one as a plugin that failed to load.
+ # NOTE: plugins/shared/ is NOT added to the FE CLASSPATH - it is loaded by
FE, not by the JVM
+ # launcher. See bin/start_fe.sh.
+ SHARED_LIB_DIR="${DORIS_OUTPUT}/fe/plugins/shared"
Review Comment:
[P2] Keep shared bundles out of the dynamic-plugin name namespace
`Config.plugin_dir` defaults to this same `fe/plugins` directory, while
`PluginInfo.readFromProperties()` accepts every nonempty name, including
`shared`. `DynamicPluginLoader.movePlugin()` maps the descriptor name directly
to `pluginDir/shared` and refuses an existing target. Because this hunk creates
that directory unconditionally—even when the Hadoop zip is absent—a valid
legacy plugin named `shared` can no longer be installed on the default layout.
Please place shared bundles outside `Config.plugin_dir/<plugin-name>`, or add
an explicit backward-compatible reservation/migration rule with install/replay
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
