xiaokang commented on code in PR #16381: URL: https://github.com/apache/doris/pull/16381#discussion_r1095295790
########## be/src/util/mem_info.cpp: ########## @@ -63,6 +63,17 @@ int64_t MemInfo::_s_sys_mem_available_warning_water_mark = 0; int64_t MemInfo::_s_process_minor_gc_size = -1; int64_t MemInfo::_s_process_full_gc_size = -1; +static std::unordered_map<std::string, int64_t> jemalloc_metrics; Review Comment: The metrics map is not atomic or protected by lock. Is there a chance to read wrong value? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
