github-actions[bot] commented on code in PR #67704:
URL: https://github.com/apache/doris/pull/67704#discussion_r3964880068
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergUtils.java:
##########
@@ -1870,6 +1880,15 @@ public static IcebergTableQueryInfo getQuerySpecSnapshot(
}
}
+ private static long timeTravelTimestampToLong(String value) {
+ try {
+ return LocalDateTime.parse(value, TIME_TRAVEL_DATETIME_FORMAT)
+
.atZone(TimeUtils.getTimeZone().toZoneId()).toInstant().toEpochMilli();
Review Comment:
[P2] Preserve the offset in committed-at round trips
This still rebuilds the instant from an offset-free wall time. During a
fall-back overlap, `$snapshots.committed_at` can render the later `2025-11-02
01:30:00.526` in `America/New_York`, but `LocalDateTime.atZone` chooses the
earlier `-04:00` occurrence instead of the original `-05:00`, moving the target
back one hour and allowing `snapshotIdAsOfTime` to select an older snapshot.
Because this PR now advertises exact committed-at round trips and the
regression strips the offset with `date_format`, that test misses this case.
Please also accept/preserve an explicit offset while retaining the existing
local-literal behavior, and cover the later occurrence of a DST overlap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
