eldenmoon commented on code in PR #66858:
URL: https://github.com/apache/doris/pull/66858#discussion_r3947663496
##########
be/src/storage/transform/block_transform.cpp:
##########
@@ -215,25 +194,16 @@ BlockTransformChain build_transform_chain(const
RowsetWriterContext& context) {
// always rebuilt.
if (context.partial_update_info->is_fixed_partial_update()) {
stages.push_back(std::make_shared<FixedPartialUpdateFillStage>());
- // The legacy fixed path parsed both provided and missing Variant
- // columns before rebuilding RowStore.
- stages.push_back(std::make_shared<VariantParseStage>());
stages.push_back(std::make_shared<RowStoreFillStage>());
} else {
stages.push_back(std::make_shared<FlexiblePartialUpdateFillStage>());
- // The legacy flexible path rebuilt RowStore before parsing the
- // filled Variant columns.
stages.push_back(std::make_shared<RowStoreFillStage>());
- stages.push_back(std::make_shared<VariantParseStage>());
}
return BlockTransformChain {std::move(stages)};
}
- // Direct and schema-change writers rebuilt RowStore from the raw Variant
- // representation, then parsed Variant for its column writer.
if (rebuild_row_store) {
Review Comment:
sparkload is experimental， so ignore in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
