bobhan1 opened a new pull request, #67579:
URL: https://github.com/apache/doris/pull/67579
### What problem does this PR solve?
Issue Number: None
Related PR: #67292
Problem Summary:
This Draft PR is for compilation validation only. It carries the current
Phase 2 branch from #67292 plus a minimal build fix. Do not merge this
validation PR.
With `ENABLE_PCH=OFF` and unity builds enabled, the IO unity translation
unit includes `err_utils.cpp` before `file_meta_cache.cpp`. The namespace-scope
`using namespace ErrorCode` in `err_utils.cpp` remains visible when the latter
includes the generated protobuf headers, making `PPlanFragmentCancelReason_MIN
= LIMIT_REACH` ambiguous between `doris::LIMIT_REACH` and
`doris::ErrorCode::LIMIT_REACH`. PCH previously parsed these headers before the
using-directive could affect them.
Move the using-directive into the two `localfs_error` overloads that need
it. The additional fix changes one file with two insertions and two deletions
and preserves the existing error-code mappings.
### Release note
None for the additional compile fix. The Phase 2 feature changes are
described in #67292.
### Check List (For Author)
- Test:
- [x] Manual test: reproduced the original `LIMIT_REACH` compilation
failure with `ENABLE_PCH=OFF` and `ENABLE_UNITY_BUILD=ON` using `./build.sh
--be -j100`.
- [ ] Post-fix BE build: pending.
- [x] `build-support/check-build-hygiene.sh` and `git diff --check`.
- Behavior changed:
- [x] No runtime behavior change in the additional compile fix.
- Does this need documentation?
- [x] No additional documentation for this compile fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
