morningman commented on PR #67504:
URL: https://github.com/apache/doris/pull/67504#issuecomment-5555169237
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67504
commit: 888313142ef112a5dd52d4e536259832b16e3852
base: b58b2c53ff56354c692c2dc7634d724d8780838f
reviewed_at: 2026-09-06T06:19+08:00
reviewer: morningman
model: claude-opus-5[1m]
effort: max
findings: {blocker: 0, major: 0, minor: 14, nit: 4}
rounds: 2
converged: true
```
**Notes for maintainers**
- `fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:1598` —
the gate also un-defers `finalizeQuery()`, so an ACID Hive scan's metastore
read lock is committed inside GetFlightInfo, before DoGet. Reviewed as Major on
the previous head; rated Minor here because the blast radius is exactly Hive
ACID (every other connector inherits the no-op `releaseReadTransaction`, per
`PluginDrivenScanNode.java:1471-1474`) and that read path is slated for
deprecation. Still worth fixing; suggested patch in the review document.
-
`regression-test/suites/external_table_p0/iceberg/test_iceberg_arrow_flight_split_source.groovy:128-162`
— the (external, non-batch, Arrow Flight) row that had no coverage anywhere is
now covered by this head's test commit, with a negative control on the split
path and an eager-release assertion. That closes the only other Major from the
previous review.
- `fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:1109-1117`
— the mirror case is still open: a deferred batch-mode Flight query never
closes its connector statement scope.
-
`fe/fe-core/src/test/java/org/apache/doris/qe/ArrowFlightDeferralGateTest.java:57-68`
— the unit test named for the deferral gate does not exercise the gate.
-
`regression-test/suites/external_table_p0/iceberg/test_iceberg_arrow_flight_split_source.groovy:171-174`
— the idle-reaper assertions give the reaper zero timing margin, which can
reproduce #62259 as a false red in CI.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
