u70b3 commented on PR #66857: URL: https://github.com/apache/doris/pull/66857#issuecomment-5449558496
Hi @gavinchou @yiguolei @Gabriel39 @morningman — gentle ping for review when you have a moment. This PR fixes several aarch64 (ARM64) correctness bugs reproduced on real ARM hardware (128-core server): a non-atomic CAS in the crash-handler election, AArch32 asm in the startup NEON check, a hardcoded x86-64 bfd target, and a SIMD popcount path silently compiled out on aarch64. It also adds zero-cost alignment-UB / memory-ordering hardening and the build fixes needed to compile master on a current aarch64 toolchain. Every fix carries a regression test, and buildall CI is running now. The PR spans a few independent fault domains — I'm happy to split it into per-theme PRs if that makes review and backporting easier. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
