github-actions[bot] commented on code in PR #67119:
URL: https://github.com/apache/doris/pull/67119#discussion_r3852911174
##########
.github/workflows/checkstyle.yaml:
##########
@@ -26,6 +26,9 @@ jobs:
java-checkstyle:
name: "CheckStyle"
runs-on: ubuntu-latest
+ concurrency:
+ group: fe-code-style-${{ github.event.pull_request.number ||
github.run_id }}
+ cancel-in-progress: true
Review Comment:
[P1] Keep historical reruns out of the current-PR group
These groups are keyed only by PR number, so rerunning an older workflow
attempt after head B's check starts lets the old attempt join the same group
and cancel (or replace while pending) B's validation. GitHub reruns retain the
original `GITHUB_SHA`/`GITHUB_REF`, so the replacement still checks head A and
cannot restore validation for B. The same issue is present in the new Clang
Formatter, Gitleaks, and License Check blocks. Please isolate
`github.run_attempt > 1` with a run-unique group such as `github.run_id`;
changing only `cancel-in-progress` does not protect a pending current-head job
because the default queue replaces an existing pending member.
##########
.github/workflows/code-review-runner.yml:
##########
@@ -55,19 +55,27 @@ permissions:
jobs:
code-review:
runs-on: ubuntu-latest
+ concurrency:
Review Comment:
[P1] Preserve status ownership across manual supersession
This shared group includes issue-comment runs, which always manage the
`code-review` status, and manual dispatches where `manage_status` can be set to
`false`. A false-status dispatch can cancel `/review` after it posts `pending`,
complete its own review, and skip both terminal status writes;
`code-review-sync-result.yml` has no review-completion trigger to repair the
stranded status. Please require every replacement admitted to this group to
take over status management, or isolate non-status-managing runs until there is
an explicit ownership handoff.
##########
.github/workflows/code-review-runner.yml:
##########
@@ -55,19 +55,27 @@ permissions:
jobs:
code-review:
runs-on: ubuntu-latest
+ concurrency:
+ group: code-review-${{ inputs.pr_number || github.event.issue.number ||
github.run_id }}
+ cancel-in-progress: true
# Pre-finalization steps can use 183 minutes and auth sync can use 8 more,
# leaving 12 minutes for runner setup and post-job cleanup.
timeout-minutes: 203
+ # Retry with a new /review request so an older workflow rerun cannot
replace
+ # the latest review for the same PR.
if: >-
- inputs.pr_number != '' ||
+ github.run_attempt == 1 &&
Review Comment:
[P1] Fence by logical request order, not concurrency admission order
`run_attempt == 1` excludes historical reruns, but two fresh requests still
both pass. GitHub documents that concurrency is ordered by when a job starts
waiting for the group, not workflow dispatch/event time, and ordering is not
guaranteed. If older request A reaches this job after newer B, A becomes the
latest entrant and cancels B, preserving A's older focus or explicit head/base
inputs. Please add a monotonic latest-request ownership check/fence rather than
treating scheduler admission order as request freshness.
##########
.github/workflows/code-review-runner.yml:
##########
@@ -55,19 +55,27 @@ permissions:
jobs:
code-review:
runs-on: ubuntu-latest
+ concurrency:
+ group: code-review-${{ inputs.pr_number || github.event.issue.number ||
github.run_id }}
+ cancel-in-progress: true
Review Comment:
[P1] Make expected supersession cancellation-safe
Once a running review has resolved its inputs, a newer request cancels the
review step, but the existing `always()` path treats `steps.review.outcome ==
'cancelled'` as a genuine error. Canceled Doris run `31655483365` concretely
posted "Review step was cancelled" to PR 66473 and reset the status to pending.
The same run then spent the rest of GitHub's five-minute cancellation window in
Litefuse and was killed before session or refreshed-auth sync began; commit
`296b8f2bc0d` explicitly requires that auth write-back after unrelated review
failure because Codex may already have refreshed the credential. Please exclude
cancellation from genuine-failure reporting and give refreshed auth a strictly
bounded early persistence path (or cooperative/external handoff) before
optional telemetry/session work.
##########
.github/workflows/code-review-runner.yml:
##########
@@ -55,19 +55,27 @@ permissions:
jobs:
code-review:
runs-on: ubuntu-latest
+ concurrency:
+ group: code-review-${{ inputs.pr_number || github.event.issue.number ||
github.run_id }}
Review Comment:
[P2] Canonicalize the PR number before admission
`inputs.pr_number` is a raw string here, and GitHub accepts equivalent forms
such as `67119`, `067119`, and `00067119` for the same pull request. Those
supported dispatch/call inputs create different group names, so they can run in
parallel with each other or with `/review` instead of coalescing per PR. Please
strictly canonicalize and validate the numeric identifier in a prerequisite
resolver, then key this job from its canonical output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
