github-actions[bot] commented on code in PR #15967:
URL: https://github.com/apache/doris/pull/15967#discussion_r1090113898
##########
be/src/vec/common/hash_table/string_hash_map.h:
##########
@@ -213,13 +213,13 @@
template <typename TMapped, typename Allocator>
struct HashTableTraits<StringHashMap<TMapped, Allocator>> {
static constexpr bool is_phmap = false;
- static constexpr bool is_parallel_phmap = false;
static constexpr bool is_string_hash_table = true;
+ static constexpr bool is_partitioned_table = false;
};
template <template <typename> class Derived, typename TMapped, typename
Allocator>
struct HashTableTraits<Derived<StringHashMap<TMapped, Allocator>>> {
Review Comment:
warning: no template named 'HashTableTraits'; did you mean
'HashTableGrower'? [clang-diagnostic-error]
```suggestion
struct HashTableGrower<Derived<StringHashMap<TMapped, Allocator>>> {
```
**be/src/vec/common/hash_table/hash_table.h:243:** 'HashTableGrower'
declared here
```cpp
struct HashTableGrower {
^
```
##########
be/src/vec/common/hash_table/string_hash_map.h:
##########
@@ -213,13 +213,13 @@
template <typename TMapped, typename Allocator>
struct HashTableTraits<StringHashMap<TMapped, Allocator>> {
Review Comment:
warning: template argument for non-type template parameter must be an
expression [clang-diagnostic-error]
```cpp
struct HashTableTraits<StringHashMap<TMapped, Allocator>> {
^
```
**be/src/vec/common/hash_table/hash_table.h:242:** template parameter is
declared here
```cpp
template <size_t initial_size_degree = 10>
^
```
##########
be/src/vec/common/hash_table/string_hash_table.h:
##########
@@ -662,6 +662,6 @@ class StringHashTable : private boost::noncopyable {
template <typename SubMaps>
struct HashTableTraits<StringHashTable<SubMaps>> {
Review Comment:
warning: explicit specialization of undeclared template struct
'HashTableTraits' [clang-diagnostic-error]
```cpp
struct HashTableTraits<StringHashTable<SubMaps>> {
^
```
##########
be/src/vec/common/hash_table/string_hash_table.h:
##########
@@ -662,6 +662,6 @@
template <typename SubMaps>
struct HashTableTraits<StringHashTable<SubMaps>> {
Review Comment:
warning: no template named 'HashTableTraits'; did you mean
'HashTableGrower'? [clang-diagnostic-error]
```suggestion
struct HashTableGrower<StringHashTable<SubMaps>> {
```
**be/src/vec/common/hash_table/hash_table.h:243:** 'HashTableGrower'
declared here
```cpp
struct HashTableGrower {
^
```
##########
be/src/vec/common/hash_table/string_hash_map.h:
##########
@@ -213,13 +213,13 @@ class StringHashMap : public
StringHashTable<StringHashMapSubMaps<TMapped, Alloc
template <typename TMapped, typename Allocator>
struct HashTableTraits<StringHashMap<TMapped, Allocator>> {
Review Comment:
warning: no template named 'HashTableTraits'; did you mean
'HashTableGrower'? [clang-diagnostic-error]
```suggestion
struct HashTableGrower<StringHashMap<TMapped, Allocator>> {
```
**be/src/vec/common/hash_table/hash_table.h:243:** 'HashTableGrower'
declared here
```cpp
struct HashTableGrower {
^
```
##########
be/src/vec/common/hash_table/string_hash_map.h:
##########
@@ -213,13 +213,13 @@
template <typename TMapped, typename Allocator>
struct HashTableTraits<StringHashMap<TMapped, Allocator>> {
static constexpr bool is_phmap = false;
- static constexpr bool is_parallel_phmap = false;
static constexpr bool is_string_hash_table = true;
+ static constexpr bool is_partitioned_table = false;
};
template <template <typename> class Derived, typename TMapped, typename
Allocator>
struct HashTableTraits<Derived<StringHashMap<TMapped, Allocator>>> {
Review Comment:
warning: template argument for non-type template parameter must be an
expression [clang-diagnostic-error]
```cpp
struct HashTableTraits<Derived<StringHashMap<TMapped, Allocator>>> {
^
```
**be/src/vec/common/hash_table/hash_table.h:242:** template parameter is
declared here
```cpp
template <size_t initial_size_degree = 10>
^
```
##########
be/src/vec/common/hash_table/string_hash_table.h:
##########
@@ -662,6 +662,6 @@
template <typename SubMaps>
struct HashTableTraits<StringHashTable<SubMaps>> {
Review Comment:
warning: template argument for non-type template parameter must be an
expression [clang-diagnostic-error]
```cpp
struct HashTableTraits<StringHashTable<SubMaps>> {
^
```
**be/src/vec/common/hash_table/hash_table.h:242:** template parameter is
declared here
```cpp
template <size_t initial_size_degree = 10>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
