github-actions[bot] commented on code in PR #66954: URL: https://github.com/apache/doris/pull/66954#discussion_r3841848299
########## be/benchmark/benchmark_predicate_vectorization.hpp: ########## @@ -0,0 +1,117 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <benchmark/benchmark.h> + +#include <cstdint> + +#include "common/compiler_util.h" +#include "core/pod_array.h" + +namespace doris { +namespace { + +using ByteVector = PaddedPODArray<uint8_t>; + +NO_INLINE void raw_or_current(ByteVector& combined, const ByteVector& child) { + for (size_t row = 0; row < combined.size(); ++row) { Review Comment: [P2] Keep the raw benchmark baseline identical to production The pre-PR production loop already used `row < num_values`; this `current` kernel uses `combined.size()`, while the optimized kernel additionally hoists that size into `rows`. The comparison therefore measures a loop-bound change that is not part of the production hunk and can inflate the cited raw-mask speedup. Please pass the same explicit `num_values`/`rows` to both kernels, vary only indexed access versus cached data pointers, and rerun the Release benchmark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
