morrySnow commented on code in PR #16197:
URL: https://github.com/apache/doris/pull/16197#discussion_r1089979474
##########
regression-test/suites/nereids_function_p0/scalar_function/R-W.groovy:
##########
@@ -122,62 +119,56 @@ suite("nereids_scalar_fn_4") {
qt_sql "select sm3sum(kstr) from fn_test order by kstr"
sql "select sm4_decrypt(kvchrs1, kvchrs1) from fn_test order by kvchrs1,
kvchrs1"
sql "select sm4_decrypt(kstr, kstr) from fn_test order by kstr, kstr"
- // core
- // sql "select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1) from fn_test order
by kvchrs1, kvchrs1, kvchrs1"
+
+ sql "select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1) from fn_test order by
kvchrs1, kvchrs1, kvchrs1"
sql "select sm4_decrypt(kstr, kstr, kstr) from fn_test order by kstr,
kstr, kstr"
- // cannot find function
- // qt_sql "select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1, kvchrs1) from
fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1"
- // qt_sql "select sm4_decrypt(kstr, kstr, kstr, kstr) from fn_test order
by kstr, kstr, kstr, kstr"
+ qt_sql """ select sm4_decrypt(kvchrs1, kvchrs1, kvchrs1, "SM4_128_ECB")
from fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1 """
+ qt_sql """ select sm4_decrypt(kstr, kstr, kstr, "SM4_128_ECB") from
fn_test order by kstr, kstr, kstr, kstr """
sql "select sm4_encrypt(kvchrs1, kvchrs1) from fn_test order by kvchrs1,
kvchrs1"
sql "select sm4_encrypt(kstr, kstr) from fn_test order by kstr, kstr"
sql "select sm4_encrypt(kvchrs1, kvchrs1, kvchrs1) from fn_test order by
kvchrs1, kvchrs1, kvchrs1"
sql "select sm4_encrypt(kstr, kstr, kstr) from fn_test order by kstr,
kstr, kstr"
- // cannot find function
- // qt_sql "select sm4_encrypt(kvchrs1, kvchrs1, kvchrs1, kvchrs1) from
fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1"
- // qt_sql "select sm4_encrypt(kstr, kstr, kstr, kstr) from fn_test order
by kstr, kstr, kstr, kstr"
+ qt_sql """ select sm4_encrypt(kvchrs1, kvchrs1, kvchrs1, "SM4_128_ECB")
from fn_test order by kvchrs1, kvchrs1, kvchrs1, kvchrs1"""
+ qt_sql """ select sm4_encrypt(kstr, kstr, kstr, "SM4_128_ECB") from
fn_test order by kstr, kstr, kstr, kstr"""
Review Comment:
what will happen, if the last arg is illegal, such as '1234'. the legacy
planner return `NULL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
