Gabriel39 commented on PR #66999: URL: https://github.com/apache/doris/pull/66999#issuecomment-5391657904
Thanks for the update. One correctness blocker remains in the large-count path: every sharded carrier is still an unrestricted whole-dataset split. A pre-change BE ignores `table_level_row_count` and scans that whole snapshot, so rolling upgrades can count the dataset once per carrier; a current BE that declines the metadata shortcut can take the same fallback path. Please make carrier fallback ranges disjoint (for example, group fragment IDs and attach the matching logical count), or retain a single carrier until the scalar path is compatibility-safe. Also, the `lanceVersion=4` EXPLAIN assertion only checks `plannedVersion`; it does not verify the version serialized in `TLanceFileDesc`, so the fixed-version fallback needs a direct range-descriptor or forced-fallback test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
