csun5285 commented on code in PR #66849:
URL: https://github.com/apache/doris/pull/66849#discussion_r3840256300


##########
be/src/storage/iterator/block_reader.cpp:
##########
@@ -75,6 +76,57 @@ Status BlockReader::next_block_with_aggregation(Block* 
block, bool* eof) {
     return res;
 }
 
+// Resolves row-binlog AFTER/BEFORE companions once from the physical tablet 
schema, then maps
+// their unique ids into the dense ReadSchema ordinals consumed by 
BlockReader. Physical pairing
+// avoids ambiguous name lookup when a user column resembles a generated 
BEFORE column.
+void BlockReader::_init_row_binlog_column_ordinals() {

Review Comment:
   ReadSchema::_before_column_ordinals 已经有这个映射了,应该使用ReadSchema 
中的映射,如果别的下标之间的映射,也都放在 ReadSchema 中



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to