github-actions[bot] commented on code in PR #67045: URL: https://github.com/apache/doris/pull/67045#discussion_r3836975644
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/MapFromArrays.java: ########## @@ -0,0 +1,86 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions.scalar; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.PreferPushDownProject; +import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature; +import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable; +import org.apache.doris.nereids.trees.expressions.shape.BinaryExpression; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.ArrayType; +import org.apache.doris.nereids.types.DataType; +import org.apache.doris.nereids.types.MapType; +import org.apache.doris.nereids.types.NullType; +import org.apache.doris.nereids.types.TinyIntType; +import org.apache.doris.nereids.types.coercion.AnyDataType; +import org.apache.doris.nereids.types.coercion.FollowToAnyDataType; +import org.apache.doris.nereids.util.TypeCoercionUtils; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; + +import java.util.List; + +/** Construct a Map from key and value arrays with identical per-row offsets. */ +public class MapFromArrays extends ScalarFunction + implements BinaryExpression, ExplicitlyCastableSignature, PropagateNullable, PreferPushDownProject { + + public static final List<FunctionSignature> SIGNATURES = ImmutableList.of( + FunctionSignature.ret(MapType.of(new FollowToAnyDataType(0), new FollowToAnyDataType(1))) + .args(ArrayType.of(new AnyDataType(0)), ArrayType.of(new AnyDataType(1)))); + + public MapFromArrays(Expression keys, Expression values) { + super("map_from_arrays", keys, values); + } + + private MapFromArrays(ScalarFunctionParams functionParams) { + super(functionParams); + } + + @Override + public MapFromArrays withChildren(List<Expression> children) { + Preconditions.checkArgument(children.size() == 2); + return new MapFromArrays(getFunctionParams(children)); + } + + @Override + public List<FunctionSignature> getSignatures() { + return SIGNATURES; + } + + @Override + public FunctionSignature computeSignature(FunctionSignature signature) { + FunctionSignature resolvedSignature = super.computeSignature(signature); Review Comment: [P1] Keep precision independent across the two map sides `AnyDataType(0)` and `AnyDataType(1)` define independent key/value families, but this `super.computeSignature` call runs one generic precision pass across both. With the default DECIMAL settings, a `DECIMAL(38,0)` key and `DECIMAL(38,38)` value are both cast to `DECIMAL(38,6)`, losing 32 fractional digits from the value. There is a second lossy path for nested time values: scale extraction stops at `StructType`, while replacement recurses into it, so a `DATETIMEV2(0)` key plus a `STRUCT<DATETIMEV2(6)>` value rewrites the value field to scale 0 and drops its microseconds. These casts happen before map construction/folding and also break `map_from_arrays(map_keys(m), map_values(m))` preservation. Please preserve the already-resolved array item types by bypassing the generic time/DECIMAL promotion here, and cover both cases end to end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
