github-actions[bot] commented on code in PR #16123:
URL: https://github.com/apache/doris/pull/16123#discussion_r1083432080
##########
be/src/http/action/checksum_action.h:
##########
@@ -25,11 +25,11 @@ namespace doris {
class ExecEnv;
-class ChecksumAction : public HttpHandler {
+class CheckSumAction : public HttpHandler {
public:
- explicit ChecksumAction();
+ explicit CheckSumAction();
- virtual ~ChecksumAction() {}
+ virtual ~CheckSumAction() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
virtual ~CheckSumAction() = default;
```
##########
be/src/http/action/checksum_action.cpp:
##########
@@ -41,9 +41,9 @@ const std::string TABLET_ID = "tablet_id";
const std::string TABLET_VERSION = "version";
const std::string SCHEMA_HASH = "schema_hash";
-ChecksumAction::ChecksumAction() {}
+CheckSumAction::CheckSumAction() {}
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
CheckSumAction::CheckSumAction() = default;
```
##########
be/src/http/action/checksum_action.h:
##########
@@ -25,11 +25,11 @@
class ExecEnv;
-class ChecksumAction : public HttpHandler {
+class CheckSumAction : public HttpHandler {
public:
- explicit ChecksumAction();
+ explicit CheckSumAction();
- virtual ~ChecksumAction() {}
+ virtual ~CheckSumAction() {}
Review Comment:
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
```suggestion
~CheckSumAction() override {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
