github-actions[bot] commented on code in PR #15633:
URL: https://github.com/apache/doris/pull/15633#discussion_r1082186196
##########
be/test/olap/cumulative_compaction_policy_test.cpp:
##########
@@ -647,18 +647,18 @@ TEST_F(TestSizeBasedCumulativeCompactionPolicy,
_level_size) {
for (auto& rowset : rs_metas) {
_tablet_meta->add_rs_meta(rowset);
}
-
+ config::compaction_promotion_size_mbytes = 1024;
TabletSharedPtr _tablet(new Tablet(_tablet_meta, nullptr,
CUMULATIVE_SIZE_BASED_POLICY));
_tablet->init();
SizeBasedCumulativeCompactionPolicy* policy =
dynamic_cast<SizeBasedCumulativeCompactionPolicy*>(
_tablet->_cumulative_compaction_policy.get());
Review Comment:
warning: '_cumulative_compaction_policy' is a private member of
'doris::Tablet' [clang-diagnostic-error]
```cpp
_tablet->_cumulative_compaction_policy.get());
^
```
**be/src/olap/tablet.h:440:** declared private here
```cpp
std::shared_ptr<CumulativeCompactionPolicy>
_cumulative_compaction_policy;
^
```
##########
be/test/olap/cumulative_compaction_policy_test.cpp:
##########
@@ -647,18 +647,18 @@
for (auto& rowset : rs_metas) {
_tablet_meta->add_rs_meta(rowset);
}
-
+ config::compaction_promotion_size_mbytes = 1024;
TabletSharedPtr _tablet(new Tablet(_tablet_meta, nullptr,
CUMULATIVE_SIZE_BASED_POLICY));
_tablet->init();
SizeBasedCumulativeCompactionPolicy* policy =
dynamic_cast<SizeBasedCumulativeCompactionPolicy*>(
_tablet->_cumulative_compaction_policy.get());
- EXPECT_EQ(536870912, policy->_levels[0]);
- EXPECT_EQ(268435456, policy->_levels[1]);
- EXPECT_EQ(134217728, policy->_levels[2]);
- EXPECT_EQ(67108864, policy->_levels[3]);
+ EXPECT_EQ(1 << 29, policy->_level_size(1 << 30));
Review Comment:
warning: '_level_size' is a private member of
'doris::SizeBasedCumulativeCompactionPolicy' [clang-diagnostic-error]
```cpp
EXPECT_EQ(1 << 29, policy->_level_size(1 << 30));
^
```
**be/src/olap/cumulative_compaction_policy.h:158:** declared private here
```cpp
int64_t _level_size(const int64_t size);
^
```
##########
be/test/olap/cumulative_compaction_policy_test.cpp:
##########
@@ -647,18 +647,18 @@
for (auto& rowset : rs_metas) {
_tablet_meta->add_rs_meta(rowset);
}
-
+ config::compaction_promotion_size_mbytes = 1024;
TabletSharedPtr _tablet(new Tablet(_tablet_meta, nullptr,
CUMULATIVE_SIZE_BASED_POLICY));
_tablet->init();
SizeBasedCumulativeCompactionPolicy* policy =
dynamic_cast<SizeBasedCumulativeCompactionPolicy*>(
_tablet->_cumulative_compaction_policy.get());
- EXPECT_EQ(536870912, policy->_levels[0]);
- EXPECT_EQ(268435456, policy->_levels[1]);
- EXPECT_EQ(134217728, policy->_levels[2]);
- EXPECT_EQ(67108864, policy->_levels[3]);
+ EXPECT_EQ(1 << 29, policy->_level_size(1 << 30));
+ EXPECT_EQ(0, policy->_level_size(1000));
Review Comment:
warning: '_level_size' is a private member of
'doris::SizeBasedCumulativeCompactionPolicy' [clang-diagnostic-error]
```cpp
EXPECT_EQ(0, policy->_level_size(1000));
^
```
**be/src/olap/cumulative_compaction_policy.h:158:** declared private here
```cpp
int64_t _level_size(const int64_t size);
^
```
##########
be/test/olap/cumulative_compaction_policy_test.cpp:
##########
@@ -647,18 +647,18 @@
for (auto& rowset : rs_metas) {
_tablet_meta->add_rs_meta(rowset);
}
-
+ config::compaction_promotion_size_mbytes = 1024;
TabletSharedPtr _tablet(new Tablet(_tablet_meta, nullptr,
CUMULATIVE_SIZE_BASED_POLICY));
_tablet->init();
SizeBasedCumulativeCompactionPolicy* policy =
dynamic_cast<SizeBasedCumulativeCompactionPolicy*>(
_tablet->_cumulative_compaction_policy.get());
- EXPECT_EQ(536870912, policy->_levels[0]);
- EXPECT_EQ(268435456, policy->_levels[1]);
- EXPECT_EQ(134217728, policy->_levels[2]);
- EXPECT_EQ(67108864, policy->_levels[3]);
+ EXPECT_EQ(1 << 29, policy->_level_size(1 << 30));
+ EXPECT_EQ(0, policy->_level_size(1000));
+ EXPECT_EQ(1 << 20, policy->_level_size((1 << 20) + 100));
+ EXPECT_EQ(1 << 19, policy->_level_size((1 << 20) - 100));
Review Comment:
warning: '_level_size' is a private member of
'doris::SizeBasedCumulativeCompactionPolicy' [clang-diagnostic-error]
```cpp
EXPECT_EQ(1 << 19, policy->_level_size((1 << 20) - 100));
^
```
**be/src/olap/cumulative_compaction_policy.h:158:** declared private here
```cpp
int64_t _level_size(const int64_t size);
^
```
##########
be/test/olap/cumulative_compaction_policy_test.cpp:
##########
@@ -647,18 +647,18 @@
for (auto& rowset : rs_metas) {
_tablet_meta->add_rs_meta(rowset);
}
-
+ config::compaction_promotion_size_mbytes = 1024;
TabletSharedPtr _tablet(new Tablet(_tablet_meta, nullptr,
CUMULATIVE_SIZE_BASED_POLICY));
_tablet->init();
SizeBasedCumulativeCompactionPolicy* policy =
dynamic_cast<SizeBasedCumulativeCompactionPolicy*>(
_tablet->_cumulative_compaction_policy.get());
- EXPECT_EQ(536870912, policy->_levels[0]);
- EXPECT_EQ(268435456, policy->_levels[1]);
- EXPECT_EQ(134217728, policy->_levels[2]);
- EXPECT_EQ(67108864, policy->_levels[3]);
+ EXPECT_EQ(1 << 29, policy->_level_size(1 << 30));
+ EXPECT_EQ(0, policy->_level_size(1000));
+ EXPECT_EQ(1 << 20, policy->_level_size((1 << 20) + 100));
Review Comment:
warning: '_level_size' is a private member of
'doris::SizeBasedCumulativeCompactionPolicy' [clang-diagnostic-error]
```cpp
EXPECT_EQ(1 << 20, policy->_level_size((1 << 20) + 100));
^
```
**be/src/olap/cumulative_compaction_policy.h:158:** declared private here
```cpp
int64_t _level_size(const int64_t size);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
