github-actions[bot] commented on code in PR #16089:
URL: https://github.com/apache/doris/pull/16089#discussion_r1082136781
##########
be/src/olap/olap_server.cpp:
##########
@@ -684,42 +685,19 @@ Status
StorageEngine::submit_seg_compaction_task(BetaRowsetWriter* writer,
void StorageEngine::_cooldown_tasks_producer_callback() {
int64_t interval = config::generate_cooldown_task_interval_sec;
+ phmap::parallel_flat_hash_set<int64_t> cooldown_pending_tabelts;
do {
- if (_cooldown_thread_pool->get_queue_size() > 0) {
- continue;
- }
+ // these tables are ordered by priority desc
std::vector<TabletSharedPtr> tablets;
// TODO(luwei) : a more efficient way to get cooldown tablets
_tablet_manager->get_cooldown_tablets(&tablets);
Review Comment:
warning: too few arguments to function call, expected 2, have 1
[clang-diagnostic-error]
```cpp
_tablet_manager->get_cooldown_tablets(&tablets);
^
```
**be/src/olap/tablet_manager.h:138:** 'get_cooldown_tablets' declared here
```cpp
nfo_on_disk);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
