morningman commented on code in PR #15836:
URL: https://github.com/apache/doris/pull/15836#discussion_r1082109767
##########
be/src/vec/exec/format/table/iceberg_reader.cpp:
##########
@@ -59,8 +59,52 @@ IcebergTableReader::IcebergTableReader(GenericReader*
file_format_reader, Runtim
ADD_CHILD_TIMER(_profile, "DeleteRowsSortTime", iceberg_profile);
}
+Status IcebergTableReader::init_reader(
+ std::vector<std::string>& file_col_names,
Review Comment:
```suggestion
const std::vector<std::string>& file_col_names,
const std::unordered_map<int, std::string>& col_id_name_map,
cosnt std::unordered_map<std::string, ColumnValueRangeType>*
colname_to_value_range,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
