yiguolei commented on code in PR #66472:
URL: https://github.com/apache/doris/pull/66472#discussion_r3757513247
##########
be/src/storage/schema.cpp:
##########
@@ -17,90 +17,143 @@
#include "storage/schema.h"
-#include <glog/logging.h>
-
-#include <boost/iterator/iterator_facade.hpp>
-#include <ostream>
-#include <unordered_set>
#include <utility>
#include "common/config.h"
-#include "core/column/column_array.h"
-#include "core/column/column_decimal.h"
+#include "common/logging.h"
+#include "core/block/block.h"
#include "core/column/column_dictionary.h"
-#include "core/column/column_map.h"
+#include "core/column/column_nothing.h"
#include "core/column/column_nullable.h"
-#include "core/column/column_string.h"
-#include "core/column/column_struct.h"
-#include "core/column/column_vector.h"
-#include "core/data_type/data_type.h"
-#include "core/data_type/data_type_factory.hpp"
-#include "core/data_type/define_primitive_type.h"
-#include "core/types.h"
-#include "storage/olap_common.h"
-#include "util/trace.h"
+#include "storage/binlog.h"
namespace doris {
-Schema::Schema(const Schema& other) {
- _copy_from(other);
+ReadSchema::ReadSchema(std::vector<TabletColumnPtr> columns)
+ : _read_columns(std::move(columns)),
_num_block_columns(_read_columns.size()) {
+ _init_read_types();
+ _init_descriptors();
}
-Schema& Schema::operator=(const Schema& other) {
- if (this != &other) {
- _copy_from(other);
+ReadSchema::ReadSchema(const std::vector<TabletColumnPtr>& columns,
+ const std::vector<ColumnId>& cids)
+ : _num_block_columns(cids.size()) {
+ _read_columns.reserve(cids.size());
+ for (auto cid : cids) {
+ _read_columns.emplace_back(columns[cid]);
}
- return *this;
+ _init_read_types();
+ _init_descriptors();
+}
+
+ReadSchema::ReadSchema(std::vector<TabletColumnPtr> columns,
std::vector<DataTypePtr> read_types)
+ : _read_columns(std::move(columns)),
Review Comment:
什么时候，我们的read type 跟 tablet column 不一样？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
