github-actions[bot] commented on code in PR #66631:
URL: https://github.com/apache/doris/pull/66631#discussion_r3754365163
##########
fe/fe-core/src/main/java/org/apache/doris/qe/VariableMgr.java:
##########
@@ -1083,6 +1083,9 @@ public static void forceUpdateVariables() {
VariableMgr.refreshDefaultSessionVariables(updateInfo,
SessionVariable.ENABLE_SQL_CACHE,
String.valueOf(true));
+ VariableMgr.refreshDefaultSessionVariables(updateInfo,
Review Comment:
This extends a migration fence that released clusters have already consumed.
A 3.1 image can contain planner=false/version=300; released 4.0 builds migrate
that image to version 400 without changing this flag. On a later maintenance
upgrade, replay restores false/400 before `forceUpdateVariables()`, so `400 <
400` is false and this assignment never runs. Please add a fresh one-shot
version (for example, `VARIABLE_VERSION_401`, made current, with only this
assignment under `< 401`) and make the regression start from version 400 plus
planner=false. Otherwise already-upgraded clusters remain on the legacy planner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
