mymeiyi commented on code in PR #66598:
URL: https://github.com/apache/doris/pull/66598#discussion_r3747099051
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -4382,15 +4481,36 @@ void
MetaServiceImpl::get_delete_bitmap(google::protobuf::RpcController* control
// FIXME: Don't expose the implementation details of
splitting large value.
// merge splitted large values (>90*1000)
if (ver != last_ver || seg_id != last_seg_id) {
+ auto sequence =
+ out.size() == 8
+ ? static_cast<uint16_t>(
+
std::get<int64_t>(std::get<0>(out[7])) & 0xffff)
+ : uint16_t {0};
+ last_ver = ver;
+ last_seg_id = seg_id;
+ // Key-based pre-rowset cleanup may leave an obsolete
tail if its size estimate is
+ // too small. The bitmap is already aggregated, so the
tail can be skipped and will
+ // be recycled with its rowset.
+ skip_last_delete_bitmap = sequence != 0;
Review Comment:
all Meta Service instances are upgraded before any BE is upgraded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
