github-actions[bot] commented on code in PR #66594:
URL: https://github.com/apache/doris/pull/66594#discussion_r3746345270
##########
fe/fe-core/src/main/java/org/apache/doris/dictionary/DictionaryManager.java:
##########
@@ -524,6 +523,13 @@ public void dataLoad(ConnectContext ctx, Dictionary
dictionary, boolean adaptive
dictionary.getVersion(),
ctx.getStatementContext().getDictionaryUsedSrcVersion());
}
+ static String buildDataLoadSql(Dictionary dictionary) {
+ String targetName = Utils.qualifiedNameWithBackquote(
Review Comment:
[P1] Preserve the structured target name past parsing
A dictionary name containing an embedded `.` is legal when the default
`enable_unicode_name_support=true`, but this quoted two-part target is
discarded by `InsertIntoDictionaryCommand`. `UnboundDictionarySink` rebuilds
its name parts with `dictionary.getNameWithFullQualifiers().split("\\.")`, so a
name such as `dict.with.dot` becomes more than three parts;
`InsertIntoTableCommand.initPlan()` then fails in
`RelationUtil.getQualifierName()` before the dictionary-specific target
override runs. The new test stops at the pre-replacement parser AST and does
not cover an embedded-dot target, so this advertised identifier fix still
leaves that dictionary unable to refresh. Please preserve
`dictionary.getFullQualifiers()` as structured parts in the replacement sink
and cover the production conversion/planning path with an embedded-dot target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
