CalvinKirs opened a new pull request, #66596:
URL: https://github.com/apache/doris/pull/66596
### What problem does this PR solve?
Problem Summary:
In cloud mode, when a JDBC catalog's `driver_url` was a bare jar name that
existed in neither the new (`$DORIS_HOME/plugins/jdbc_drivers`) nor the old
(`$DORIS_HOME/jdbc_drivers`) default directory,
`JdbcResource.checkAndReturnDefaultDriverUrl()` fell back to downloading the
jar from the meta-service object store via `CloudPluginDownloader`.
Two reasons to drop it:
- The path has had no real users for a long time.
- Staging third-party JDBC drivers is not something the kernel should own.
Getting the jar onto the FE node is an ops/deployment concern, exactly as it
already is in non-cloud mode.
This PR removes the cloud branch so JDBC driver resolution is purely local
and behaves identically in both modes. When the jar is absent, FE now reports
the existing `JDBC driver file does not exist: xxx` instead of a cloud download
failure.
`CloudPluginDownloader` itself is deliberately left untouched -- the Java
UDF path in `CreateFunctionCommand` still uses it. Only the JDBC caller goes
away.
The `test_cloud_plugin_auto_download` regression suite is trimmed
accordingly: the JDBC catalog case and the non-existent-driver negative case
are removed, all UDF cases are kept as-is.
### Release note
In cloud mode, a JDBC catalog's `driver_url` is no longer auto-downloaded
from cloud storage. Place the driver jar under
`$DORIS_HOME/plugins/jdbc_drivers/`, or use a full URL, or set
`jdbc_drivers_dir`.
### Check List (For Author)
- Test
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [ ] No.
- [x] Yes. In cloud mode, a bare-jar-name `driver_url` that is not
present in the default drivers directory is no longer fetched from cloud
storage; it now fails with `JDBC driver file does not exist`.
- Does this need documentation?
- [ ] No.
- [x] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01UhnPBBERkwB2TDsnVA4wvH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
