zhannngchen commented on code in PR #16034: URL: https://github.com/apache/doris/pull/16034#discussion_r1080711046
########## be/src/runtime/tablets_channel.cpp: ########## @@ -242,7 +242,7 @@ Status TabletsChannel::_open_all_writers(const PTabletWriterOpenRequest& request wrequest.tuple_desc = _tuple_desc; wrequest.slots = index_slots; wrequest.is_high_priority = _is_high_priority; - wrequest.ptable_schema_param = request.schema(); + wrequest.table_schema_param = _schema; Review Comment: `_schema` is inited from `request.schema()`, and it's life cycle is longer than delta writers, so we can use `_schema` directly to avoid copying the schema twice(the first time is here, the second time is in the ctor of DeltaWriter) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org