acarofpigs opened a new pull request, #66556:
URL: https://github.com/apache/doris/pull/66556
### What problem does this PR solve?
Issue Number: close #66430
Related PR: None
Problem Summary:
A compressed Parquet DataPageV2 can legally contain definition levels but no
physical values when every nullable value is NULL. The legacy reader passed the
resulting null, zero-length slice to the BOOLEAN PLAIN decoder and aborted the
BE in BatchedBitReader::Reset().
Use a dedicated empty-value-section decoder for these pages. Accept the page
when definition levels require no physical values, and return Corruption when
values are required but absent. Update page progress only after decoding
succeeds so failures leave reader state unchanged.
### Release note
Fix a BE crash when reading Parquet pages with empty value sections.
### Check List (For Author)
- Test
- [x] Unit Test - ./run-be-ut.sh --run \
--filter=ParquetColumnChunkReaderTest.* -j 2 - 11 tests passed with ASAN
- [x] Manual test
- ./build.sh --be -j 2
- Behavior changed:
- [x] Yes. Valid all-NULL pages are accepted, while inconsistent pages
return Corruption instead of aborting the BE.
- Does this need documentation?
- [x] No.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
