englefly opened a new pull request, #66518:
URL: https://github.com/apache/doris/pull/66518
Issue Number: None
Related PR: None
Problem Summary: Executing an INSERT into a table whose LIST partitions
contain MAXVALUE (e.g. `PARTITION p4 VALUES IN ((NULL, MAXVALUE))`) fails on
the FE with `TProtocolException: Required field 'node_type' was not present!`
while serializing the plan fragments to the BE. Root cause:
OlapTableSink.setPartitionKeys converts every partition key literal of a LIST
partition into TOlapTablePartition.in_keys, but the MAXVALUE literal
(MaxLiteral.MAX_VALUE) has no thrift conversion
(ExprToThriftVisitor.visitMaxLiteral is an empty stub), so the produced
TExprNode has no node_type, which is a required thrift field. The RANGE branch
already skips max-value endpoints (`!range.upperEndpoint().isMaxValue()`),
while the LIST branch has no such guard. Fix: skip in-key tuples that contain
MAXVALUE at any position when building the sink partition param, mirroring the
RANGE branch's skip logic.
None
- Test: Regression test (test_auto_list_partition_null extended with INSERT
into a table containing MAXVALUE LIST partitions) passed
- Behavior changed: No
- Does this need documentation: No
[fix](fe) Do not prune list partitions containing MAXVALUE
Issue Number: None
Related PR: None
Problem Summary: Querying a table whose LIST partitions contain MAXVALUE
(e.g. `PARTITION p4 VALUES IN ((NULL, MAXVALUE))`) with a predicate on the
partition columns fails with "Can not get value from max literal". The Nereids
partition pruner converts every partition key literal into a concrete literal
(OneListPartitionEvaluator.getInputsByOneSlot/getInputsByMultiSlots) and
evaluates the predicate against it, but MaxLiteral has no value, so evaluation
throws. Fix: a partition whose keys contain MAXVALUE cannot be evaluated
against the predicate, so it is kept conservatively and the predicate is not
pruned, mirroring the existing default-partition handling in canBePrunedOut.
None
- Test: Regression test (test_auto_list_partition_null extended with a
predicate query on the partition columns) passed
- Behavior changed: No
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
