eldenmoon commented on code in PR #66204: URL: https://github.com/apache/doris/pull/66204#discussion_r3719187058
########## be/src/storage/segment/variant/v2/variant_assembler.cpp: ########## @@ -0,0 +1,692 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: 1. try_build_typed_storage_cells 两遍遍历性能可能有影响 2. split_storage_path 是否没必要， 直接starts_with、类似path_is_prefix也是没必要， 直接starts_with， 再检查下别的地方， 如果是 有 . 的地方直接可以认为是object 层级 3. VariantAssembledColumn, PreparedStorageMap， PreparedRoot， 没必要引入 4. part_key 函数是不是可以不引入 5. compare_path_parts 是不是可以删除，如果不用校验 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
