github-actions[bot] commented on code in PR #66397:
URL: https://github.com/apache/doris/pull/66397#discussion_r3706302893
##########
be/benchmark/parquet/AGENTS.md:
##########
@@ -51,7 +51,7 @@ be/output/lib/benchmark_test --benchmark_list_tests \
| grep -c '^ParquetDecoder/' # currently 228
be/output/lib/benchmark_test --benchmark_list_tests \
- | grep -c '^ParquetKernel/' # currently 92
+ | grep -c '^ParquetKernel/' # currently 292
Review Comment:
Please update the `Current validation record` below as part of this count
change. It still says `92 kernel`, while this command and the matrix
description now correctly expect 292 (92 existing plus 200 nullable-selection
cases). The guide currently gives reviewers contradictory pass/fail criteria.
##########
be/test/format_v2/parquet/parquet_reader_control_test.cpp:
##########
@@ -186,6 +187,79 @@ TEST(SelectionVectorTest,
IdentitySelectionDoesNotMaterializeFilter) {
EXPECT_EQ(filter, nullptr);
}
+TEST(NativeNullableSelectionTest,
BuildsPhysicalRangesAndSelectedNullsInOnePass) {
Review Comment:
The new tests exercise `build_filtered_nullable_selection()` and the
eligibility predicate directly, but none drives the actual
`ScalarColumnReader::_read_values()` branch into
`materialize_fused_nullable_values()`. That leaves the new wiring unprotected:
a regression in nonzero `_filter_map_index`, page/`_remaining_num_values`
advancement, or nullable expansion could pass all of these tests. Please add a
reader-level case with at least 1,024 fragmented nullable rows and a partial
filter, assert the values and NULL layout, then read a subsequent batch/page so
the production path and cursor continuation are covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
