github-actions[bot] commented on code in PR #66302:
URL: https://github.com/apache/doris/pull/66302#discussion_r3701862667
##########
be/src/format_v2/parquet/parquet_statistics.cpp:
##########
@@ -463,7 +782,7 @@ bool has_expr_zonemap_filter(const format::FileScanRequest&
request, const Runti
return true;
}
}
- return false;
+ return has_variant_shredded_filter(request);
Review Comment:
[P1] Keep Variant metadata pruning behind the unsafe-conjunct fence
This new Variant-only trigger can prune a Row Group or page from any
localized Variant comparison even when an earlier original conjunct is
unsafe/error-preserving. TableReader records
`_constant_pruning_safe_filter_count` specifically so pre-execution cannot
cross that barrier, but `FileScanRequest` does not carry it and the Variant
statistics loops inspect every localized conjunct. For example, an earlier
slotless `assert_true(...)` followed by an excluding `CAST(v['k'] AS INT) =
999` can return no rows from metadata without executing the assertion. Please
carry and honor the original safe-prefix boundary here (or disable this pruning
after an unsafe conjunct), with footer- and page-index coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
