gavinchou commented on code in PR #65810:
URL: https://github.com/apache/doris/pull/65810#discussion_r3695887629
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/stream/BaseTableStream.java:
##########
@@ -81,7 +81,7 @@ public static TBinlogScanType toThrift(StreamScanType
streamScanType) {
@SerializedName("sir")
protected boolean showInitialRows;
- @SerializedName("bti")
+ @SerializedName(value = "bti", alternate = "sti")
Review Comment:
why? we dont need alternative because we haven't release any versions
contains `rowbinlog` feature.
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -1568,6 +1583,18 @@ Status CloudMetaMgr::update_tmp_rowset(const RowsetMeta&
rs_meta, int64_t table_
return st;
}
+Status CloudMetaMgr::update_tmp_rowsets(const RowsetMeta& rs_meta,
Review Comment:
ditto, wrapping the existing
##########
gensrc/proto/olap_file.proto:
##########
@@ -718,6 +715,8 @@ message TabletMetaPB {
optional int64 time_series_compaction_level_threshold = 33 [default = 1];
optional EncryptionAlgorithmPB encryption_algorithm = 34;
optional int32 vertical_compaction_num_columns_per_group = 35 [default =
5];
+ optional bool is_row_binlog_tablet = 36 [default = false];
+ optional int64 binlog_tablet_id = 37;
Review Comment:
consider using an enum TabletType instead of `is_row_binlog`
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -1530,6 +1529,22 @@ Status CloudMetaMgr::commit_rowset(RowsetMeta& rs_meta,
const std::string& job_i
return st;
}
+Status CloudMetaMgr::commit_rowsets(RowsetMeta& rs_meta, RowsetMeta&
attach_row_binlog,
Review Comment:
sugguest renaming the existing `commit_rowsets()` as `do_commit_rowsets()`
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -552,6 +555,8 @@ void
MetaServiceImpl::batch_get_version(::google::protobuf::RpcController* contr
response->clear_partition_ids();
response->clear_table_ids();
response->clear_versions();
+ response->clear_version_update_time_ms();
Review Comment:
was `clear_version_update_time_mswas` a bug before this commit?
##########
be/src/cloud/cloud_meta_mgr.h:
##########
@@ -84,9 +84,16 @@ class CloudMetaMgr {
Status commit_rowset(RowsetMeta& rs_meta, const std::string& job_id,
int64_t table_id,
std::shared_ptr<RowsetMeta>* existed_rs_meta =
nullptr);
+
+ Status commit_rowsets(RowsetMeta& rs_meta, RowsetMeta& attach_row_binlog,
Review Comment:
why not just add a new param to the existing function?
##########
be/src/cloud/cloud_meta_mgr.h:
##########
@@ -84,9 +84,16 @@ class CloudMetaMgr {
Status commit_rowset(RowsetMeta& rs_meta, const std::string& job_id,
int64_t table_id,
std::shared_ptr<RowsetMeta>* existed_rs_meta =
nullptr);
+
+ Status commit_rowsets(RowsetMeta& rs_meta, RowsetMeta& attach_row_binlog,
+ const std::string& job_id, int64_t table_id,
+ std::shared_ptr<RowsetMeta>* existed_rs_meta =
nullptr,
+ std::shared_ptr<RowsetMeta>*
existed_attach_row_binlog = nullptr);
void cache_committed_rowset(RowsetMetaSharedPtr rs_meta, int64_t
expiration_time);
Status update_tmp_rowset(const RowsetMeta& rs_meta, int64_t table_id);
+ Status update_tmp_rowsets(const RowsetMeta& rs_meta, const RowsetMeta&
attach_row_binlog,
Review Comment:
ditto
##########
gensrc/proto/olap_file.proto:
##########
@@ -718,6 +715,8 @@ message TabletMetaPB {
optional int64 time_series_compaction_level_threshold = 33 [default = 1];
optional EncryptionAlgorithmPB encryption_algorithm = 34;
optional int32 vertical_compaction_num_columns_per_group = 35 [default =
5];
+ optional bool is_row_binlog_tablet = 36 [default = false];
+ optional int64 binlog_tablet_id = 37;
Review Comment:
missing comments for these new fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
